D5748: workaround for correct wayland positioning

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> view.cpp:237
> +            if (!s) {
> +                return PlasmaQuick::Dialog::event(event);
>              }

return retval.

otherwise you're processsing it twice.

> view.cpp:248
> +            //positionOnScreen tried to position it in the position it already had, so no moveevent happens and we need to manually posiyion the surface
> +            m_plasmaShellSurface->setPosition(position());
>          }

When we get here we've already run Dialog::event()

won't that have already done the positioning?

There's a virtual geometry method in dialog to allow krunner and such to be different

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D5748

To: mart, #plasma, #plasma_on_wayland
Cc: davidedmundson, graesslin, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170512/f7a59a0d/attachment.html>