D4997: Support for long running kcheckpass supporting multiple authentications
Tobias C. Berner
tcberner at freebsd.org
Fri May 12 07:18:01 UTC 2017
Hi there
I think this review introduced some Linux-only features: signalfd() is
only present on Linux.
So this breaks kcheckpass on FreeBSD (and probably everything non-Linux too).
Would it be possible to have the long-running auth stuff hidden behind a
check_include_file("sys/signalfd.h" HAVE_SIGNALFD_H)
check?
mfg Tobias
On 19 April 2017 at 17:44, Martin Gräßlin <noreply at phabricator.kde.org> wrote:
> This revision was automatically updated to reflect the committed changes.
> Closed by commit R133:07d38ba65adc: Support for long running kcheckpass
> supporting multiple authentications (authored by graesslin). View Revision
>
> REPOSITORY
> R133 KScreenLocker
>
> CHANGES SINCE LAST UPDATE
> https://phabricator.kde.org/D4997?vs=13188&id=13603
>
> REVISION DETAIL
> https://phabricator.kde.org/D4997
>
> AFFECTED FILES
> greeter/authenticator.cpp
> greeter/authenticator.h
> greeter/autotests/authenticatortest.cpp
> greeter/greeterapp.cpp
> kcheckpass/kcheckpass-enums.h
> kcheckpass/kcheckpass.c
> tests/kcheckpass_test.cpp
>
> To: graesslin, Plasma
> Cc: subdiff, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed,
> jensreuterberg, abetts, sebas, apol
More information about the Plasma-devel
mailing list