D5747: add pid to plasma window management protocol

Sebastian Kügler noreply at phabricator.kde.org
Thu May 11 14:23:25 UTC 2017


sebas updated this revision to Diff 14407.
sebas marked 3 inline comments as done.
sebas added a comment.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.


  Address review comments
  
  - Minor corrections in docs
  - Use uint for the pid
  - uint32 for pids instead of int32
  - Fix @since in docs
  - send initial value when it's not 0
  - Add autotest in TestWindowManagement as well

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5747?vs=14249&id=14407

BRANCH
  sebas/processid

REVISION DETAIL
  https://phabricator.kde.org/D5747

AFFECTED FILES
  autotests/client/test_plasma_window_model.cpp
  autotests/client/test_wayland_windowmanagement.cpp
  src/client/plasmawindowmanagement.cpp
  src/client/plasmawindowmanagement.h
  src/client/plasmawindowmodel.cpp
  src/client/plasmawindowmodel.h
  src/client/protocols/plasma-window-management.xml
  src/server/plasmawindowmanagement_interface.cpp
  src/server/plasmawindowmanagement_interface.h

To: sebas, #plasma, hein, graesslin
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170511/0ffd55ca/attachment.html>


More information about the Plasma-devel mailing list