Review Request 130006: Avoid showing wrong timezone suffix in krunner time

Ronnie Thomas ronnietom at gmail.com
Mon May 8 15:09:17 UTC 2017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130006/
-----------------------------------------------------------

(Updated May 8, 2017, 3:09 p.m.)


Status
------

This change has been discarded.


Review request for Plasma.


Repository: kdeplasma-addons


Description
-------

Krunner is suffixing the local timezone when asked for the time of other regions. QLocale doesn't provide a way to set the locale based only on the country (which is provided by QDateTime), so it would be better if we just use the short time format and avoid showing the timezone altogether.


Diffs
-----

  runners/datetime/datetimerunner.cpp f65b1b337 

Diff: https://git.reviewboard.kde.org/r/130006/diff/


Testing
-------


File Attachments
----------------

Current time in my place
  https://git.reviewboard.kde.org/media/uploaded/files/2017/03/11/e6493a90-7ff9-4312-b844-5fb42dd19eae__Screenshot_20170311_222230.png
Before patch
  https://git.reviewboard.kde.org/media/uploaded/files/2017/03/11/30587d90-3f49-494e-9519-9ef0a4d5b370__Screenshot_20170311_222126.png
After patch
  https://git.reviewboard.kde.org/media/uploaded/files/2017/03/11/b2109259-36a4-4b1a-aa73-750bead3569e__Screenshot_20170311_222355.png


Thanks,

Ronnie Thomas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170508/4b046d6c/attachment.html>


More information about the Plasma-devel mailing list