D5761: Removal of KDELibs4Support means own copy of FindSamba.cmake needed
Jonathan Marten
noreply at phabricator.kde.org
Mon May 8 10:26:19 UTC 2017
marten created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This CMake module used to be provided by KDELibs4Support. Since the removal of that dependency from kio-extras, the module is not found and the SMB ioslave cannot be built.
This differential takes a local copy of the module from KDELibs4Support in kio-extras. No other part of KDE frameworks or Plasma appears to need Samba, therefore this approach should be preferable to copying it into ECM.
TEST PLAN
Copied this file into kio-extras/cmake source directory and built.
Samba libraries (from Samba 4.2.14) are found, and the SMB ioslave is built and works correctly.
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D5761
AFFECTED FILES
cmake/FindSamba.cmake
To: marten, #plasma, dfaure
Cc: plasma-devel, jriddell, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170508/16000a35/attachment.html>
More information about the Plasma-devel
mailing list