D5731: Fix regression for timestamp handling for Xwayland windows

Martin Gräßlin noreply at phabricator.kde.org
Sat May 6 17:54:13 UTC 2017


graesslin created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.

REVISION SUMMARY
  Change https://phabricator.kde.org/R108:0bec9ad7337536e319c17c5684d97e1156399fdb introduced a regrssion
  on Wayland. On Wayland getTimestamp always returns 0, thus the X11
  timestamp gets reset again and again. This results in broken interaction
  for Xwayland windows as the broken unit tests show.
  
  This change addresses the regression by ignoring a value of 0.
  It means the addressed bug is still present on Wayland for X11 windows
  as the timestamp doesn't get updated properly. This requires further
  changes.

TEST PLAN
  TestShade works again, testX11TimestampUpdate still works

REPOSITORY
  R108 KWin

BRANCH
  fix-timestamp-regression-try2-5.8

REVISION DETAIL
  https://phabricator.kde.org/D5731

AFFECTED FILES
  main.h

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170506/9dcd2f3b/attachment.html>


More information about the Plasma-devel mailing list