D5695: Applet: Automatically raise maximum volume when over defined maximum volume

[Sebastian Kügler]

sebas added a comment.


  You're right, forgot to submit the cosmetical comment.

INLINE COMMENTS

> ListItemBase.qml:282
> +                if (!slider.forceRaiseMaxVolume && Volume > PulseAudio.NormalVolume) {
> +                    Volume = PulseAudio.NormalVolume;
> +                }

Should be "volume", since that's the property. Or perhaps we don't need "volume" or "Volume".

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  auto-raise-volume (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D5695

To: drosca, #plasma, sebas
Cc: sebas, Zren, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170506/1a15fb83/attachment.html>