D5705: AppMenu: Don't call AboutToShow on LayoutUpdated

[David Rosca]

drosca created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This workaround is there (according to the comment) for Firefox,
  but I still don't get any appmenu in Firefox at all.
  It breaks applications that rely on aboutToShow/aboutToHide signals,
  because it sends aboutToShow to all menus on startup without actually
  the menu being opened.
  
  BUG: 375053

TEST PLAN
  Fixes linked bug.
  MenuImporter::fakeUnityAboutToShow is now no longer used, so if this fix is accepted,
  the patch should be changed to remove the whole function and connections instead of
  just commenting the call.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  dbusmenu-fakeunity (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D5705

AFFECTED FILES
  appmenu/menuimporter.cpp

To: drosca, #plasma
Cc: plasma-devel, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170503/91690a4d/attachment-0001.html>