D5695: Applet: Automatically raise maximum volume when over defined maximum volume

[David Rosca]

drosca added a comment.


  In https://phabricator.kde.org/D5695#106714, @Zren wrote:
  
  > I'm guessing the side effect of this method is that if you uncheck "force boost" when the volume is 150%, it will stay at 150% volume until you manually slide it down to below 100%? If it does, wouldn't it then set the slider.maxValue to 100%, causing the volume to jump from 100% down to 66% (since you'd be 1/3 of the way down the slider when the max jumps from 150% to 100%).
  >
  > If that does happen, we probably need a `if (!forced && volume > 100%) volume = 100%` when you uncheck it.
  
  
  Good catch, thanks.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D5695

To: drosca, #plasma
Cc: Zren, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170503/8f875fcd/attachment.html>