D5250: cursors: Make build scripts more generic; build more sizes

[Roman Gilg]

subdiff added a comment.


  Script looks very nice! I will test run it tomorrow. One thing we have to keep in mind when adding additional cursor sizes is the automatic (resolution dependent) cursor size mode. Adding many sizes with small differences could make the chosen size ambiguous or the algorithm to select the size become inefficient. But I would start from the premise that this is not case. Let's make sure though by looking into it shortly as well.
  
  Regarding your comments in your bug report: After my initial comment I hadn't looked into it again till today when I noticed your Diff here on Phab, so that's why I haven't responded. The Breeze repo is also currently without maintainer, so that's why there were not many other reactions. Thanks for the later responses to Dominik and Andreas therefore!

INLINE COMMENTS

> build.sh:1
>  #!/bin/bash
>  # Open initial output.

Leave this file at mode 644.

> build.sh:14
>  ALIASES="src/cursorList"
> +SIZES="24 32 40 48 64 96"
>  

What about the 36px size? It is scaling factor 1.5, therefore quite common.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D5250

To: jamesl
Cc: subdiff, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170329/0b17a19c/attachment.html>