D5242: fixes for plasmawindowed sni support

Aleix Pol Gonzalez noreply at phabricator.kde.org
Wed Mar 29 18:18:29 UTC 2017


apol requested changes to this revision.
apol added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> plasmawindowedcorona.cpp:64
>      v->show();
> -
> +qWarning()<<"AAAAAA"<<applet;
>      KConfigGroup appletsGroup(KSharedConfig::openConfig(), "Applets");

!

> plasmawindowedview.cpp:215
>      if (ev->matches(QKeySequence::Quit)) {
> +        m_statusNotifier->deleteLater();
>          close();

`m_statusNotifier` should be a `QPointer`?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D5242

To: mart, apol
Cc: apol, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170329/8839b824/attachment.html>


More information about the Plasma-devel mailing list