D5221: [desktop:/ KIO] Add descriptive name for root item

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kio_desktop.cpp:171
> +    // Set a descriptive display name for the root item
> +    if (entry.stringValue(KIO::UDSEntry::UDS_NAME) == QLatin1String(".")) {
> +        entry.insert(KIO::UDSEntry::UDS_DISPLAY_NAME, i18n("Desktop Folder"));

This will be wrong in subdirs of desktop:/, as you mentioned in the description, no?

You can do if (requestedUrl().path() == "/" && ....)
where requestedUrl() is a method from the base class ForwardingSlaveBase.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D5221

To: broulik, #plasma, hein, dfaure, elvisangelaccio
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170329/c81a65df/attachment.html>