D5226: [Folder View] Use toDisplayString which strips passwords

Tue Mar 28 16:05:38 UTC 2017

broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Otherwise we might be leaking sensitive information.

TEST PLAN
  I want to get this in before https://phabricator.kde.org/D5223 so I can rebase it ontop of this and save me a merge-dance.

  Configured URL as `sftp://foo:bar@example.com` and neither the default label type nor the "full path" would reveal the password.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D5226

AFFECTED FILES
  containments/desktop/plugins/folder/labelgenerator.cpp

To: broulik, #plasma, hein
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170328/bbed936f/attachment.html>