D4614: [Baloo Widgets] Add KPropertiesDialog Plugin with file metadata

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> broulik wrote in baloofilepropertiesplugin.desktop:8
> I went through all extractors in KFileMetaData and looked at what they support.
> 
> Unfortunately KPropertiesDialog does not support wildcards. But then, showing this tab only for files where we can get meaningful information (read: stuff that isn't already on the main tab like file size and modified date), is probably better anyway.

Well, as soon as your wrote all/all in the list, everything else was moot, since that means "any file or dir".
I think you want to remove all/all, based on what you wrote in the above comment.

(Note that whoever says all/all should say application/octet-stream instead, all/all is deprecated. Possibly adding inode/directory if directories should be supported too.)

Something else: your list of ServiceTypes contains many mimetypes; this works, but for clarity you should move them all to the MimeType key, and leave only KPropertiesDialog/Plugin as servicetype (which it is).

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D4614

To: broulik, #plasma, #vdg, dfaure, aacid
Cc: fabianr, ltoscano, davidedmundson, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170328/cce69eeb/attachment.html>