D5112: Make archiver ioslave extensible

David Faure noreply at phabricator.kde.org
Mon Mar 27 19:40:58 UTC 2017


dfaure added a comment.


  The idea sounds OK to me.

INLINE COMMENTS

> CMakeLists.txt:32
> +    FILE KF5KioArchiveTargets.cmake
> +    NAMESPACE KF5::
> +)

The KF5 prefix is wrong, this isn't part of KF5.

> CMakeLists.txt:44
> +
> +add_library(KF5KioArchive kio_archivebase.cpp kio_archive_debug.cpp)
> +

The KF5 prefix is wrong, this isn't part of KF5.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D5112

To: marten, #plasma, dfaure
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170327/810a994a/attachment-0001.html>


More information about the Plasma-devel mailing list