D4806: [greeter] Send the auth result through the server instead return value

[Roman Gilg]

subdiff added a comment.


  In https://phabricator.kde.org/D4806#97351, @graesslin wrote:
  
  > reapVerify seems to me to be only if the communication horribly breaks.
  
  
  I don't think that's the case, because otherwise greeter could've never read in the exit code of kcheckpass on current master.
  
  It's more like this: In kcheckpass.c the method conv_server() first sends `GSendInt()`, which applies to one of the cases in `handleVerify()`. Then (in the cases ConvGetNormal and ConvGetHidden) conv_server() sends again a string via `GSendStr`. For checkpass_shadow.c this is the 0 string, which then falls through to `reapVerify()`.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D4806

To: graesslin, #plasma
Cc: subdiff, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170326/f1191082/attachment.html>