D5162: Port custom image mode to IconItem.

Aleix Pol Gonzalez noreply at phabricator.kde.org
Thu Mar 23 23:21:39 UTC 2017


apol added inline comments.

INLINE COMMENTS

> CompactRepresentation.qml:30
> +    readonly property bool useCustomButtonImage: (plasmoid.configuration.useCustomButtonImage
> +        && plasmoid.configuration.customButtonImage != "")
>      property QtObject dashWindow: null

I've read several times that it's more efficient to check empty strings by doing `something.length != 0`.

I don't have data, but it kind of makes sense.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D5162

To: hein, #plasma, broulik
Cc: apol, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170323/6570ce15/attachment-0001.html>


More information about the Plasma-devel mailing list