D5137: Add support for screenedge touchscreen events through XInput 2.2

David Edmundson noreply at phabricator.kde.org
Thu Mar 23 10:34:24 UTC 2017


davidedmundson added inline comments.

INLINE COMMENTS

> davidedmundson wrote in xinputintegration.cpp:132
> I think we want to always update m_lastTouchPositions outside of 
> if (e->detail == m_trackingTouchId)
> 
> otherwise if we get:
> 
> TouchBegin
> TouchUpdate
> TouchOwnership
> 
> we start the gesture in the wrong position

Sorry that's not quite what i meant

m_lastTouchPositions now needs to use e->detail

And the gestureRecognizer stuff should still be inside the if.

REVISION DETAIL
  https://phabricator.kde.org/D5137

To: graesslin, #plasma, #kwin
Cc: davidedmundson, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170323/f478c6f2/attachment.html>


More information about the Plasma-devel mailing list