D5106: Add support for activating screenedges through touch swipe gestures

Martin Gräßlin noreply at phabricator.kde.org
Sun Mar 19 17:48:28 UTC 2017


graesslin marked 4 inline comments as done.
graesslin added inline comments.

INLINE COMMENTS

> davidedmundson wrote in screenedge.cpp:473
> Note that the only subclass of Edge doesn't call the super class for any of the virtual methods: doGeom/activate/deactivate.
> 
> To fit the current pattern this should be in setGeometry / reserve / unreserve respectively
> 
> (and yes, I know the current only subclass of Edge isn't relevant in this case)

Not sure about this one. I thought of just calling the parent method when adding it on X11. Also long term I want to get rid of the WindowBasedEdge and just use XInput2.

REVISION DETAIL
  https://phabricator.kde.org/D5106

To: graesslin, #kwin, #plasma_on_wayland
Cc: davidedmundson, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170319/4525cf75/attachment.html>


More information about the Plasma-devel mailing list