D5080: do not add debugger button unless it is meant to be visible

Harald Sitter noreply at phabricator.kde.org
Fri Mar 17 12:12:53 UTC 2017


sitter created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  QDBBox explicitly calls show() and hide() all over the place ultimately
  resulting in the button being visible when in fact we do not want it to
  be.

TEST PLAN
  - without patch I always get a debug button despite showExternalDebuggers returning false
  - with patch I don't

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5080

AFFECTED FILES
  drkonqi/drkonqidialog.cpp

To: sitter, broulik
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170317/ffdefb53/attachment.html>


More information about the Plasma-devel mailing list