D5034: Add support for x-gvfs style options in fstab

[Kai Uwe Broulik]

broulik created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  These fstab options allows an administrator to specify names and icons intended for the user, shown in a GUI.
  
  For details, see https://git.gnome.org/browse/gvfs/tree/monitor/udisks2/what-is-shown.txt

TEST PLAN
  This is a frameworks port and cleanup of https://git.reviewboard.kde.org/r/113587
  
  Placed the following in `/etc/fstab`
  
    hostname:/ /mnt/ nfs4 defaults,_netdev,user,rw,exec,comment=x-gvfs-show,x-gvfs-name=Test%20Folder,x-gvfs-icon=folder-home,timeo=14,noatime 0 0
  
  Got the following entry:
  F2800877: Screenshot_20170313_152729.png <https://phabricator.kde.org/F2800877>
  Also verified that `comment=x-gvfs-hide` hides the entry. I did not implement `x-gvfs-show` as we always show all devices no matter where they are, so the override to forcefully show it is of no use to us.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D5034

AFFECTED FILES
  src/solid/devices/backends/fstab/fstabdevice.cpp
  src/solid/devices/backends/fstab/fstabdevice.h
  src/solid/devices/backends/fstab/fstabhandling.cpp
  src/solid/devices/backends/fstab/fstabhandling.h
  src/solid/devices/backends/fstab/fstabstorageaccess.cpp
  src/solid/devices/backends/fstab/fstabstorageaccess.h

To: broulik, #plasma, dfaure
Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170313/4ae02302/attachment.html>