D4929: DrKonqi : lldb support

[René J.V. Bertin]

rjvbb added inline comments.

INLINE COMMENTS

> kfunk wrote in backtracegenerator.h:87
> Looks pretty unclean to have a backend-specific variable around here.

I suppose I could replace m_lldbDetached with something like

  bool Debugger::isDetached(const QString &outputLine=QString())
  {
      if (!outputLine.isEmpty() && codeName() == "lldb") {
          QString line = outputLine.simplified();
          if (/*line contains "Process detached"*/) {
              m_isDetached = true;
          }
      }
      return m_isDetached;
  }

and call that function instead of reading/setting m_lldbDetached.

Whether that's really less cumbersome I don't know?

REVISION DETAIL
  https://phabricator.kde.org/D4929

To: rjvbb, #plasma_workspaces, kfunk
Cc: kfunk, mart, broulik, kde-mac, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170310/70f988e3/attachment.html>