D4991: try proper order of corona()->availableScreenRect()

Marco Martin noreply at phabricator.kde.org
Thu Mar 9 17:38:39 UTC 2017


mart created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  connect to Plasma::Corona::availableScreenRectChanged
  instead of using kscreen, this way we should be more sure
  that signal is emitted when it's safe to call
  corona()->availableScreenRect() as the change of rect
  may happen after a screen removal, so may mean
  accessing a desktop view while being deleted
  BUG:377298

TEST PLAN
  notifications still pop up in the proper place,
  couldn't reproduce the crash neither before nor after tough

REPOSITORY
  R120 Plasma Workspace

BRANCH
  phab/notificationsavailableScreenRectChanged

REVISION DETAIL
  https://phabricator.kde.org/D4991

AFFECTED FILES
  applets/notifications/lib/notificationsapplet.cpp
  shell/shellcorona.cpp

To: mart, #plasma
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170309/ec769342/attachment.html>


More information about the Plasma-devel mailing list