D4989: more aggressively repaint when the shadow changes

[Marco Martin]

mart created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: KWin, kwin, plasma-devel.

REVISION SUMMARY
  when some effects like maximize or translucency are
  disabled, less repaints happen and especially when
  using aurorae it's possible to trigger some repaint bugs:
  if you maximize a window then quickly unmaximize it
  by dragging the decoration away, sometimes a piece of the
  old decoration (seems only the shadow part) remains on screen
  
  this extra addLayerRepaint seems to make the problem
  harder to reproduce, even tough sometimes still happens

TEST PLAN
  maximizing and unmaximizing the window many times seems to
  leave graphics behind almost never now (unfortunately, almost
  so there is still something broken somewhere)
  the reason aurorae seems to trigger it a lot, is that a
  setShadow happens during the repaint, that is triggered by a timer.
  if like in oxygen i do a setshadow only connected to the signal
  KDecoration2::DecoratedClient::activeChanged the problem
  does not seem to happen, but of course that happens too soon
  and the graphics is still wrong.
  another possibly related bug, that seems harder to reproduce
  is in https://www.youtube.com/watch?v=IfbHVApLbyg&feature=youtu.be&t=79
  (moving the window, a piece of shadow stays there)

REPOSITORY
  R108 KWin

BRANCH
  phab/auroraerepaint

REVISION DETAIL
  https://phabricator.kde.org/D4989

AFFECTED FILES
  toplevel.cpp

To: mart, #plasma, graesslin
Cc: plasma-devel, kwin, #kwin, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170309/48a811e4/attachment.html>