D4945: QuickShare: Fix attempt for Plasma freezing when trying to paste large images to imgur

[Yuen Hoe Lim]

yuenlim created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Oddly, when pasting raw image data into QuickShare -> imgur, if the image data is sufficiently large KIO::storedHttpPost() seems to trigger a notification that reads:
  
  "Transferring: Finished" "data:image/png;base64, <the entire raw data of the image to paste>"
  
  This causes Plasma to basically freeze, presumably because the notification system isn't meant to handle megabytes of text.
  
  This strangely doesn't happen (the notification does not appear to get triggered) if the image is not too large.
  
  I am able to reliably reproduce the notification attempt + freeze with a 3000x2000 Spectacle screenshot with a sufficiently complex wallpaper, and reliably reproduce the non-buggy no notification case using smaller rectangular region screenshots.
  
  I have also found that I can "fix" the large image case by simply omitting the KIO::HideProgressInfo flag from the KIO::storedHttpPost() call in the imgur plugin code. This seems to remove the notification + freeze with no ill effects.
  
  Wondering if this might be an acceptable patch to go in, and if someone can shed some light on why I'm seeing such odd behavior :)

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D4945

AFFECTED FILES
  src/plugins/imgur/imgurplugin.cpp

To: yuenlim, #plasma, apol
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170305/c05f8998/attachment.html>