Review Request 127408: Make sure the QPlatformWindow doesn't get initialized prematurely.

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127408/
-----------------------------------------------------------

(Updated mar. 3, 2017, 4:50 p.m.)


Status
------

This change has been discarded.


Review request for Plasma.


Repository: plasma-workspace


Description
-------

* Remove the initial call to `PanelShadows::self()->addWindow(this);`. It ends up in a winId call that will force a premature construction of the QPlatformWindow.
* Only update window properties when visible


Diffs
-----

  shell/panelview.cpp c8c3c71 

Diff: https://git.reviewboard.kde.org/r/127408/diff/


Testing
-------

I made sure it doesn't end up calling `const_cast<QWindow *>(this)->create();` within `QWindow::winId()`.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170303/224e2193/attachment-0001.html>