D4922: [Folder View] Set plasmoid.busy to false when listing canceled

Kai Uwe Broulik noreply at phabricator.kde.org
Fri Mar 3 14:55:20 UTC 2017


broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  When trying to access a folder that no longer exists or a KIO slave crashes or any other kind of error, instead of listingCompleted the listingCanceled signal is emitted at which point Folder View would spin indefinitely whilst showing an error at the same time.

TEST PLAN
  Broke my desktop kio slave, got an error message but it didn't spin its spinner anymore. Spinning while loading a large directory still works.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4922

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderView.qml
  containments/desktop/plugins/folder/foldermodel.cpp
  containments/desktop/plugins/folder/foldermodel.h

To: broulik, #plasma, hein
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170303/cebdd285/attachment-0001.html>


More information about the Plasma-devel mailing list