[Differential] [Request, 56 lines] D4867: [Menu] Improved available space correction for openRelative
Roman Gilg
noreply at phabricator.kde.org
Wed Mar 1 14:42:17 UTC 2017
subdiff created this revision.
subdiff added a project: Plasma.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
There was already some kind of detection and adjustment if there is not enough space for the popup available. Do some more work by placing the popup according to its PopupPlacement enum. Do this also if the popup breaks the top or left boundary of the screen.
The goal is to never hide the parentItem, but in this revision this is yet violated for `Types::TopPosedRightAlignedPopup` and `Types::LeftPosedBottomAlignedPopup` if both respective screen limits are broken. The question is if we should it ignore it or place the popup then better to the side or bottom/top.
Tested it with my WIP patch for plasma-pa:
F2672785: 1.png <https://phabricator.kde.org/F2672785>
F2672786: 2.png <https://phabricator.kde.org/F2672786>
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4867
AFFECTED FILES
src/declarativeimports/plasmacomponents/qmenu.cpp
src/plasma/plasma.h
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: subdiff, #plasma
Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170301/6707c965/attachment-0001.html>
More information about the Plasma-devel
mailing list