[Differential] [Request, 17 lines] D4861: [ConfigCategory] Deduce name and icon from pluginName

Kai Uwe Broulik noreply at phabricator.kde.org
Wed Mar 1 13:35:18 UTC 2017


broulik created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  This way one can just add a KCM as-is without having to worry about a potentially diverging translation or icon from System Settings.

TEST PLAN
  Placed the following in plasma-pa's config.qml
  
    ConfigCategory {
        pluginName: "kcms/kcm_pulseaudio"
    }
  
  Even though I didn't specify an icon or name, it showed up.
  F2672717: Screenshot_20170301_143308.png <https://phabricator.kde.org/F2672717>
  Added a plugin which doesn't exist, printed a warning and didn't show up.
  
  It seems weird that I have to add "kcms/" prefix to it in contrast to `X-Plasma-ConfigPlugins` though, and I also didn't find anyone actually using pluginName. Also lacks a KIOSK check because of the kcms/ prefix.
  
  Maybe we should support both? We can't change force it, though, as it will be a behavior change.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4861

AFFECTED FILES
  src/plasmaquick/private/configcategory_p.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170301/7d8bddb2/attachment.html>


More information about the Plasma-devel mailing list