[Differential] [Updated] D4803: Basic keyboard support + fixes to QuickShare plasmoid

[Aleix Pol Gonzalez]

apol added a comment.


  The rest is fine, please fix this.

INLINE COMMENTS

> yuenlim wrote in AlternativesView.qml:101
> after discussion, should avoid using Plasma-specific components here (in purpose) for now. To use Rectangle without custom radius instead.

That doesn't make sense, this is not Purpose code, this is the plasmoid. This should use Highlight as Marco suggested.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D4803

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: yuenlim, mart, apol
Cc: mart, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170301/0df0aca1/attachment.html>