D6386: [Digital Clock] Allow speaking out loud current time

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> main.xml:65
> +    <entry name="announceInterval" type="Int">
> +      <label>Speak out loud current time every n minutes (0 = disabled)</label>
> +      <default>0</default>

mention it has to be a factor of 60.

> texttospeech.cpp:95
> +                            "It is %1:%2 p m",
> +                            time.hour()-12,
> +                            time.minute());

This is wrong for midday and midnight. We never have 0 for an hour, always twleve.

It's:

11am
12pm
01pm

See table on right (and yes, it makes no sense)
https://en.wikipedia.org/wiki/12-hour_clock

REVISION DETAIL
  https://phabricator.kde.org/D6386

To: broulik, #plasma, #vdg
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170629/3e108f44/attachment.html>