D6418: [XDGV6] manage every ping sent

[Marco Martin]

mart added a comment.


  In https://phabricator.kde.org/D6418#120319, @davidedmundson wrote:
  
  > > for how i did the kwin part, it must be who called it with discardTimer (this to allow kwin to receive 2 timeouts before deciding to kill the window)
  >
  > Ok, I see how it's meant to work but I don't understand why it's done like that.
  >
  > From what I see Kwayland can call "emit q->pingTimeout ; q->discardTimer() "  and your kwin code will still wait for 2 timeouts,
  
  
  in this case only one as the second timeout will never be emitted?
  what i could do, is chaning the timeout signature in pingTimeout(serial, attempt) so on kwayland-server part, it would emit timeout two times, then delte the timer by itself
  
  >> most of it is in private, just its creation is mostly identical in the implementation of ping in the subclasses
  > 
  > Yes, and I'm saying that bit could be shared as a method and called from the subclasses.
  
  +1

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D6418

To: mart, #plasma, davidedmundson, graesslin
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170629/7ccad045/attachment.html>