D6424: [Scripting] Throw a error from the Containment when the widget is not found

David Edmundson noreply at phabricator.kde.org
Wed Jun 28 20:44:13 UTC 2017


davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  In principle fine.

INLINE COMMENTS

> containment.cpp:217
>                  return env->wrap(applet);
>              }
>          }

what about this one?

> containment.cpp:230
> +
> +        return context->throwError(i18n("Could not find widget!"));
>      } else if (Widget *widget = qobject_cast<Widget*>(v.toQObject())) {

s/find/create

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D6424

To: garg, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170628/858c3736/attachment-0001.html>


More information about the Plasma-devel mailing list