D6186: Implement software cursor in OpenGL backend
Oleg Chernovskiy
noreply at phabricator.kde.org
Sun Jun 25 20:19:59 UTC 2017
Kanedias marked 2 inline comments as done.
Kanedias added inline comments.
INLINE COMMENTS
> graesslin wrote in scene_opengl.cpp:682-685
> Instead of adding an empty method you could make it pure virtual
That moment when I noticed we have no SceneOpenGL instantiations. Tx!
> graesslin wrote in scene_opengl.h:141
> you don't need to readd the virtual keyword when using override.
Should we heal other methods suffering from this? I can prepare such patch.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D6186
To: Kanedias, graesslin, davidedmundson
Cc: aacid, luebking, plasma-devel, kwin, #kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170625/a5c6c174/attachment-0001.html>
More information about the Plasma-devel
mailing list