D6047: WIP: Support XDG v6
Marco Martin
noreply at phabricator.kde.org
Fri Jun 23 11:29:42 UTC 2017
mart added inline comments.
INLINE COMMENTS
> graesslin wrote in xdgshell_interface.h:80
> @davidedmundson for the ping you could check the old wl_shell_surface implementation in KWayland.
the implementation here in xdgshell_interface is basically copied over the kwayland wl_shell_surface.
the code pasted above, is the only kwin part i found that was managing pings in any way, which is the x11 implementation (Client)
i guess ShellClient will have to have something along the lines using the kwayland implementations, tough casing between the possible interfaces exposed (wl_shell, xdgshellv5 and xdgshellv6)
> graesslin wrote in xdgshell_interface.h:75
> what is "gravity"?
as far i understood, it's an hint that tells the window the direction it prefers to popup, so like "please dear compositor make it show below the point i asked to", or at the left, or whatever
hint that the compositor can choose to ignore
REVISION DETAIL
https://phabricator.kde.org/D6047
To: davidedmundson, #plasma
Cc: graesslin, mart, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170623/e05eb6f6/attachment.html>
More information about the Plasma-devel
mailing list