D6351: KDE QFileDialog helper: support name filters without parenthesis.

David Faure noreply at phabricator.kde.org
Thu Jun 22 22:55:03 UTC 2017


dfaure created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  The QFileDialog documentation says these are equivalent:
  
    dialog.setNameFilter("All C++ files (*.cpp *.cc *.C *.cxx *.c++)");
    dialog.setNameFilter("*.cpp *.cc *.C *.cxx *.c++");
  
  so we should support both syntaxes.

TEST PLAN
  See autotest addition; also tested together with my kdialog port to QFileDialog.

BRANCH
  wildcard

REVISION DETAIL
  https://phabricator.kde.org/D6351

AFFECTED FILES
  autotests/kfiledialog_unittest.cpp
  src/platformtheme/kdeplatformfiledialoghelper.cpp

To: dfaure, #plasma, apol
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170622/d7e7147e/attachment.html>


More information about the Plasma-devel mailing list