D6334: [kcms/touchpad] Fix crash with 'Drag me' in X11 test area
Christoph Feck
noreply at phabricator.kde.org
Thu Jun 22 00:46:20 UTC 2017
cfeck created this revision.
cfeck added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Something really fishy was going on when dragging the 'Drag me' folder in the X11 test area onto itself.
Instead of using a custom QStandardItemModel with a QListView, use a QListWidget, which comes with its own model that does not allow dropping items onto other items, but It is still possible to move the icon.
Fixes https://bugs.kde.org/show_bug.cgi?id=346900 and https://bugs.kde.org/show_bug.cgi?id=366113
TEST PLAN
Could freely drag, no crash.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D6334
AFFECTED FILES
kcms/touchpad/src/kcm/xlib/testarea.cpp
kcms/touchpad/src/kcm/xlib/ui/testarea.ui
To: cfeck, #plasma, knambiar
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170622/397029fd/attachment.html>
More information about the Plasma-devel
mailing list