D6313: WIP: Support device pixel ratio in icon loader and engine

[David Edmundson]

davidedmundson added a comment.


  For SVG icons this is fine.
  
  For pixmap icons this is only part of the needed changes.
  
  We don't want to load the 16px image and then resize it, I think that's what this would do? That would be an unacceptable regression.
  
  We would need a folder containing the 16px icons at 2x. This is now part of the FD.O icon spec [1].  But that means updating all of our icon theme parsing and a much much bigger patch. 
  Or we could just special case SVGs here.
  
  [1]https://specifications.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html

INLINE COMMENTS

> kiconloader.cpp:1294
>      QPixmap pix;
> +    pix.setDevicePixelRatio(scale);
> +

I don't think you need this?

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D6313

To: broulik, kde-frameworks-devel, #plasma, #vdg
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170621/3a3fe576/attachment-0001.html>