D6188: [Desktop] Pad cellWidth/cellHeight with the extra space

[Chris Holland]

Zren added a comment.


  > https://cgit.kde.org/plasma-desktop.git/commit/?id=f49ca6ee277142539e0302f2848c79ff41d319cf
  
  @hein Good catch with the `&& isRootView`. It's just optimization since the extraSpace for the popup is 0 right? Now that I think on it, not sure why I made the variables into properties. Probably for logging `onVarChanged` when debugging it. Would this be more efficient?
  
    cellWidth: {
        if (root.useListViewMode) {
            return gridView.width;
        } else {
            var iconWidth = iconSize + (2 * units.largeSpacing) + (2 * units.smallSpacing);
            if (root.isContainment) {
                var extraWidth = calcExtraSpacing(iconWidth, scrollArea.viewportWidth);
                return iconWidth + extraWidth;
            } else {
                return iconWidth;
            }
        }
    }
  
  or is it just better to keep those properties exposed for future use?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D6188

To: Zren, hein
Cc: anthonyfieroni, broulik, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170620/eb70d78c/attachment.html>