D6282: Context: Return early from connectToDaemon when already connected

[David Rosca]

drosca created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  connectToDaemon is called after 1 second delay when PulseAudio context
  becomes invalid, but it is also called when PulseAudio service registers
  on DBus.
  
  In case when PulseAudio crashes and immediately restarts, the delayed
  call to connectToDaemon will be called when already connected which will
  open second connection and leak the first one.
  It also leads to assert with debug build.
  
  BUG: 381411

TEST PLAN
  Restarted pulseaudio, plasma-pa reconnected

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  Plasma/5.10

REVISION DETAIL
  https://phabricator.kde.org/D6282

AFFECTED FILES
  src/context.cpp

To: drosca, #plasma, apol
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170619/19e0473c/attachment.html>