D6215: Make sure size is final after showEvent
Marco Martin
noreply at phabricator.kde.org
Mon Jun 19 13:20:21 UTC 2017
mart added a comment.
In https://phabricator.kde.org/D6215#117498, @davidedmundson wrote:
> > this will work only when the Dialog' version of setvisible is called,
>
> So this will break released Plasma?
no, it just means that who calls show() or the wrong setVisible() would just get the previous behavior of mainItem being shown only at showevent, so with the potential resize/position glitch that is already in now, but setvisible gets called both there and in the showevent, so it wouldn't significantly break (just in most common case, the second setvisible would be a noop)
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D6215
To: mart, #plasma, davidedmundson
Cc: sebas, hein, davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170619/3cb0f334/attachment.html>
More information about the Plasma-devel
mailing list