D6247: Fix clicking outside of preview popups to dismiss them corrupting mouse state

Eike Hein noreply at phabricator.kde.org
Mon Jun 19 10:01:52 UTC 2017


hein added inline comments.

INLINE COMMENTS

> broulik wrote in FolderItemDelegate.qml:119
> This check is now superfluous as it's also done in `closePopup()`

Yeah, but it's minutely faster to check this than do a function call (and the dialog not being open is the common case), it's a little more careful to assume a function body doesn't check, and the function does check because it's just good practice, ... it's redundant but I'd leave it like that.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D6247

To: hein, #plasma
Cc: broulik, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170619/33512d6e/attachment-0001.html>


More information about the Plasma-devel mailing list