D6186: Implement software cursor in OpenGL backend

[Oleg Chernovskiy]

Kanedias added inline comments.

INLINE COMMENTS

> luebking wrote in scene_opengl.cpp:699
> The entire head should probably be in some init function, not in every paint call.
> If you go for a lazy init, you should seekt to prevent double connects (but I don't know whether Qt::UniqueConnection works with functors), but I'd discourage that approach, because it prevents shortcutting the function if there's no cursor image (ie. "!m_cursorTexture")

Will fix that

> luebking wrote in scene_opengl.cpp:734
> This needs a comment from Martin, but you might have to glGet with GL_BLEND_SRC and GL_BLEND_DST as well as glIsEnabled(GL_BLEND)

You mean, to check whether BLEND was enabled prior to calling this func?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D6186

To: Kanedias, graesslin, davidedmundson
Cc: luebking, plasma-devel, kwin, #kwin, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170618/242f44f9/attachment.html>