D6260: Better handle cases when the xkb keymap fails to be created

[Martin Flöser]

graesslin created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.

REVISION SUMMARY
  If the keymap cannot be created a few pointers in Xkb are null.
  We should make sure to not call any xkbcommon functions on those
  null pointers and instead use proper fallbacks.
  
  This change introduces fixes for a few usages, but it's not unlikely
  that there are more cases.
  
  BUG: 381210
  FIXED-IN: 5.10.3

TEST PLAN
  Autotest added for the condition of the bug, which does
  not crash any more. Just starting the test found a few more crash
  cases.

REPOSITORY
  R108 KWin

BRANCH
  safety-checks-xkbcommon-5.10

REVISION DETAIL
  https://phabricator.kde.org/D6260

AFFECTED FILES
  autotests/integration/CMakeLists.txt
  autotests/integration/keymap_creation_failure_test.cpp
  xkb.cpp

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170618/26b75a47/attachment.html>