D6216: simplify positioning code

Marco Martin noreply at phabricator.kde.org
Thu Jun 15 14:48:14 UTC 2017


mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in notificationshelper.cpp:294
> I find it odd that we use the contentItem height not the window height which includes the frame margins.
> 
> Especially given that whole other patch is about making sure the window is resized to the contentItem.

didn't change that, giving a try to it, may simplify things further

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D6216

To: mart, #plasma
Cc: davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170615/761188a9/attachment.html>


More information about the Plasma-devel mailing list