D3650: lower mouse acceleration limit to 0.0

Martin Flöser noreply at phabricator.kde.org
Wed Jun 14 18:48:56 UTC 2017


graesslin added a comment.


  In https://phabricator.kde.org/D3650#112888, @apol wrote:
  
  > In https://phabricator.kde.org/D3650#80584, @graesslin wrote:
  >
  > > According to my comments in the Wayland port: the value 1.0 means no acceleration. Values below 1.0 mean a de-acceleration or a slow down. But it's still a factor. I'm also afraid that putting a 0.0 there could result in a devision by 0 value.
  > >
  > > So in any case your commit message does not match the actual reality. And given that I think you are trying to fix the wrong problem. Might it be that you use the libinput xorg driver? If yes, that's not yet supported and needs porting. But this change has potential of breaking the non-libinput xorg driver then.
  > >
  > > From my side something between -1 and -2 for this change.
  >
  >
  > Does this mean that 0.0 means not moving at all? That doesn't sound right.
  
  
  It could mean a crash in X - division by zero. No idea how X handles the situation, but 0 is clearly a wrong value here.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3650

To: sitter, plasma-devel
Cc: apol, graesslin, broulik, jensreuterberg, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, abetts, sebas, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170614/1c008475/attachment.html>


More information about the Plasma-devel mailing list