D6216: simplify positioning code
Marco Martin
noreply at phabricator.kde.org
Tue Jun 13 16:38:04 UTC 2017
mart created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
drop most of the positioning code, drop the animation of the
window position. use the newly introduced aboutToShow()
signal and position the popup in its signal handler.
at that point we are sure the size is the final and correct one
the animation is supposed to be done by the morphingpopups effect
instead.
TEST PLAN
notification positions are always correct now, both on X11 and
Wayland.
Unfortunately on x11 the notification typ doesn't seem to pass,
so they are correctly animated only in wayland
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6216
AFFECTED FILES
applets/notifications/package/contents/ui/NotificationPopup.qml
applets/notifications/plugin/CMakeLists.txt
applets/notifications/plugin/notificationshelper.cpp
applets/notifications/plugin/notificationshelper.h
To: mart, #plasma
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170613/b12b68c6/attachment-0001.html>
More information about the Plasma-devel
mailing list