D6191: Simplify KNSBackend fetch logic

[Dan Leinir Turthra Jensen]

leinir marked 2 inline comments as done.
leinir added inline comments.

INLINE COMMENTS

> apol wrote in KNSBackend.cpp:109
> Add an `#if KNEWSTUFF_VERSION_MAJOR==5 && KNEWSTUFF_VERSION_MINOR==36`
> 
> We always end up forgetting these fixme

Very true, yes - to be quite frank, i forgot about the preprocessor for a moment, there ;)

> apol wrote in KNSBackend.cpp:130
> Good, maybe we should also delete them?
> Can you see if the StandardUpdater is listening to resourceRemoved?

Yes, that does seem like a good idea, if we're reasonably certain they're not accessed in other places...
StandardUpdater did not, but it does now :)

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D6191

To: leinir, apol, #discover_software_store
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170613/6f32ab3a/attachment.html>