D6201: [Desktop] Avoid binding loop on label.width by anchoring left/right to the frame

[Chris Holland]

Zren created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Is there a reason we need to have the label to be implicitWidth?
  Right now, we get a binding loop on `width: Math.min(label.implicitWidth + units.smallSpacing, parent.width - units.smallSpacing * 4)`.
  
    file:///home/chris/.local/share/plasma/plasmoids/org.kde.desktopcontainment/contents/ui/FolderItemDelegate.qml:288:17: QML Text: Binding loop detected for property "width"
  
  Also, the icon uses `units.smallSpacing` for the `leftMargin`, while the label currently uses  `2 * units.smallSpacing` for the `leftMargin`. I've changed it so they're both the same width since width is more important for the label.
  
  Before: F3782091: 2017-06-12___15-58-51.png <https://phabricator.kde.org/F3782091>
  After: F3782089: 2017-06-12___15-54-42.png <https://phabricator.kde.org/F3782089>

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D6201

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderItemDelegate.qml

To: Zren, hein
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170612/559fb337/attachment.html>