D6188: [Desktop] Pad cellWidth/cellHeight with the extra space

[Eike Hein]

hein requested changes to this revision.
hein added a comment.
This revision now requires changes to proceed.


  Looks pretty good to me. It needs some polish as marked, but we should test it in master soon.

INLINE COMMENTS

> FolderView.qml:526
> +                    }
> +                    return extraSpacing
> +                }

Coding style: missing termination semicolae (also elsewhere)

> FolderView.qml:539
> +                property int iconHeight: (iconSize + (theme.mSize(theme.defaultFont).height * plasmoid.configuration.textLines) + (6 * units.smallSpacing))
> +                property real extraHeight: calcExtraSpacing(iconHeight, scrollArea.viewportHeight)
>                  cellHeight: {

readonly (also elsewhere)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D6188

To: Zren, hein
Cc: broulik, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170612/9065aed3/attachment.html>